Attention is currently required from: Tarun Tuli, Dinesh Gehlot.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72416 )
Change subject: soc/intel/tgl: Move ME FSR structures to pertinent header
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72416/comment/d8e6f09e_71b0a743
PS3, Line 7: soc/intel/tgl: Move ME FSR structures to pertinent header
Yes, we may need to use SoC specfic Macro's to select the appropriate prints. […]
Is it not easier and cleaner defining those structs (txt_support/cpu_debug_disable) and dependent APIs into soc folder itself instead making them common?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72416
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib96fcb86fd2c3fe16f23c8f038f4930a832a5b01
Gerrit-Change-Number: 72416
Gerrit-PatchSet: 3
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Comment-Date: Wed, 01 Feb 2023 18:08:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment