Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant
......................................................................
Patch Set 17: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte...
PS14, Line 54: 15.2
PCH_i2C2_misc connect to HDMI .
"pci 15.2" is i2c2 and that does not match the comment on line 63.
according to your schematics, the touchpad is under i2c5, so this
should be changed to "pci 19.1".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea
Gerrit-Change-Number: 42301
Gerrit-PatchSet: 17
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 21 Jul 2020 00:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-MessageType: comment