Attention is currently required from: Hung-Te Lin, jason-ch chen, Paul Menzel.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74062 )
Change subject: soc/mediatek/mt8186: Reduce GPIO code size in bootblock
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74062/comment/297702b3_b50f557f
PS4, Line 9: Use the same method for memory saving to be consistent with other
: projects. The initial 1480 bytes of the GPIO driving array were
: downsized to 24 bytes.
:
Create a new GPIO driving info table that contains only the pins used in the bootblock. The GPIO driving info table is downloaded from 1480 bytes to 24 bytes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74062
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24775ba93cd74ae401747c2f5a26bbf1c8f6ac0a
Gerrit-Change-Number: 74062
Gerrit-PatchSet: 4
Gerrit-Owner: jason-ch chen
Jason-ch.Chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: jason-ch chen
Jason-ch.Chen@mediatek.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 06 Apr 2023 08:54:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment