Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76029?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for DdiPortBHpd dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for DdiPortBHpd dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="DdiPortBHpd" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: I19a4368a224ffe3739157a2b6618ba84aa35d10f Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/mainboard/google/puff/variants/baseboard/devicetree.cb M src/mainboard/google/sarien/variants/arcada/devicetree.cb M src/mainboard/google/sarien/variants/sarien/devicetree.cb M src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb M src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb M src/mainboard/protectli/vault_cml/devicetree.cb 8 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/76029/1
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index ab42668..b0562b3 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -55,7 +55,7 @@ # Enable eDP device register DdiPortEdp = true # Enable HPD for DDI ports B/C - register "DdiPortBHpd" = "1" + register DdiPortBHpd = true register "DdiPortCHpd" = "1" # Enable DDC for DDI port B register "DdiPortBDdc" = "1" diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 184860fd..5054304 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -39,7 +39,7 @@ # Enable eDP device register DdiPortEdp = true # Enable HPD for DDI ports B/C - register "DdiPortBHpd" = "1" + register DdiPortBHpd = true register "DdiPortCHpd" = "1" register "tcc_offset" = "10" # TCC of 90C # Unlock GPIO pads diff --git a/src/mainboard/google/puff/variants/baseboard/devicetree.cb b/src/mainboard/google/puff/variants/baseboard/devicetree.cb index 66a6d31..14e10dd 100644 --- a/src/mainboard/google/puff/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/puff/variants/baseboard/devicetree.cb @@ -39,7 +39,7 @@ # Enable eDP device register DdiPortEdp = true # Enable HPD for DDI ports B/C - register "DdiPortBHpd" = "1" + register DdiPortBHpd = true register "DdiPortCHpd" = "1" register "tcc_offset" = "10" # TCC of 90C # Unlock GPIO pads diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 1acfb20..41efb92 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -44,7 +44,7 @@ # Enable eDP device register DdiPortEdp = true # Enable HPD for DDI ports B/C - register "DdiPortBHpd" = "1" + register DdiPortBHpd = true register "DdiPortCHpd" = "1" # Enable DDC for DDI port B register "DdiPortBDdc" = "1" diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index 1af241c..f9a9729 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -47,7 +47,7 @@ # Enable eDP device register DdiPortEdp = true # Enable HPD for DDI ports B/C - register "DdiPortBHpd" = "1" + register DdiPortBHpd = true register "DdiPortCHpd" = "1" # Enable DDC for DDI port B register "DdiPortBDdc" = "1" diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb index e31413a..a28f8ac 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb @@ -5,7 +5,7 @@ # Enable eDP device register DdiPortEdp = true # Enable HPD for DDI ports B/C - register "DdiPortBHpd" = "1" + register DdiPortBHpd = true register "DdiPortCHpd" = "1" register "DdiPortDHpd" = "1" register "DdiPortFHpd" = "1" diff --git a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb index 1891786..3b1ca28 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb @@ -5,7 +5,7 @@ # Enable eDP device register DdiPortEdp = true # Enable HPD for DDI ports B/C/D/F - register "DdiPortBHpd" = "1" + register DdiPortBHpd = true register "DdiPortCHpd" = "1" register "DdiPortDHpd" = "1" register "DdiPortFHpd" = "1" diff --git a/src/mainboard/protectli/vault_cml/devicetree.cb b/src/mainboard/protectli/vault_cml/devicetree.cb index 44455b2..022d4db 100644 --- a/src/mainboard/protectli/vault_cml/devicetree.cb +++ b/src/mainboard/protectli/vault_cml/devicetree.cb @@ -23,7 +23,7 @@ register DdiPortEdp = true # Display Port
# Enable HPD for DDI ports B/C - register "DdiPortBHpd" = "1" # HDMI + register DdiPortBHpd = true # HDMI register "DdiPortCHpd" = "1" # USB Type-C
# Enable DDC for DDI port B