Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36334 )
Change subject: cbmem.h: Align comment with the reality of implementations
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36334/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36334/1//COMMIT_MSG@10
PS1, Line 10: in order for the implementation
I'd say this depends on the implementation, doesn't it?
A generic API should not depend on the implementation. I don't think there is a current use case to check if cbmem_top return 0 to do something.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36334
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8fe32844af290626a0f91279143fda4d3442680f
Gerrit-Change-Number: 36334
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
Gerrit-Comment-Date: Sun, 27 Oct 2019 05:30:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment