Attention is currently required from: Tim Wawrzynczak, Christian Walter.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61720 )
Change subject: drivers/i2c/tpm/cr50: Add support to get cr50 firmware version
......................................................................
Patch Set 3:
(3 comments)
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/61720/comment/bcb21719_be32ad25
PS3, Line 487: -2
Unable to understand how line #518 (the caller) would differentiate between function returning -1 or -2.
https://review.coreboot.org/c/coreboot/+/61720/comment/178b4666_152ee66f
PS3, Line 554: get_fw_version
line #499 returns the status but you are not checking this prior to below serial msg ?
https://review.coreboot.org/c/coreboot/+/61720/comment/c6de7bbd_d2edb560
PS3, Line 565: }
one blank line please
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61720
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dbdbc6ec717f1aa89111ae09249cbe2312054d9
Gerrit-Change-Number: 61720
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Wed, 09 Feb 2022 08:10:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment