Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34447 )
Change subject: soc/intel/common: Set controller state to active in uart init ......................................................................
Patch Set 4:
(9 comments)
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... File src/soc/intel/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... PS1, Line 36: struct device *dev
can u make this as first argument ?
Done
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... PS1, Line 36: static void uart_lpss_init(uintptr_t baseaddr,struct device *dev)
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... PS1, Line 39: lpss_set_power_state(dev, STATE_D0);
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... PS1, Line 39: lpss_set_power_state(dev, STATE_D0);
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... PS1, Line 39:
tab here
Done
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... PS1, Line 87: uart_lpss_init(baseaddr,device);
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... PS1, Line 87: uart_lpss_init(baseaddr,device);
one space here
Done
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... PS1, Line 230: uart_lpss_init(base,dev);
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/34447/1/src/soc/intel/common/block/... PS1, Line 230: uart_lpss_init(base,dev);
one space here
Done