Attention is currently required from: Felix Held, Zheng Bao.
Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84131?usp=email )
Change subject: amdfwtool: Add a unified function to add combo entries
......................................................................
Patch Set 4:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/84131/comment/28e348a5_a0180898?usp... :
PS3, Line 1478: /* 0 -Compare PSP ID, 1 -Compare chip family ID */
i assume that this one is related to the id_sel element two lines below, so it would be good to move […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84131?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I41c5c6fb5acf92604dd06becf1eda680a1fab545
Gerrit-Change-Number: 84131
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 11 Sep 2024 03:37:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de