Attention is currently required from: Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59135 )
Change subject: mb/google/brya/variants/primus: enable RTD3 for PCIe-eMMC bridge ......................................................................
Patch Set 2:
(5 comments)
File src/mainboard/google/brya/variants/primus/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132931): https://review.coreboot.org/c/coreboot/+/59135/comment/32113b04_5e2b01ee PS2, Line 21: if (child->chip_ops == &soc_intel_common_block_pcie_rtd3_ops) suspect code indent for conditional statements (16, 16)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132931): https://review.coreboot.org/c/coreboot/+/59135/comment/91890acc_eb2d65c3 PS2, Line 22: rtd3_dev = child; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132931): https://review.coreboot.org/c/coreboot/+/59135/comment/349e41f5_19a641b5 PS2, Line 22: rtd3_dev = child; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132931): https://review.coreboot.org/c/coreboot/+/59135/comment/ba759143_e6077428 PS2, Line 28: rtd3_dev->enabled = 0; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132931): https://review.coreboot.org/c/coreboot/+/59135/comment/39b4669c_5eb02610 PS2, Line 34: devtree_update_emmc_rtd3(board_ver); please, no spaces at the start of a line