Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: cpucp loading changes ......................................................................
Patch Set 31:
(42 comments)
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/f0dca2a1_7e1968ae PS31, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/24e22427_c3df3624 PS31, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/2b9192b4_110d4986 PS31, Line 16: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/6fd5887a_bfa1fb75 PS31, Line 16: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/c36224ee_ffa941e2 PS31, Line 18: /* allow NS access to EPSS memory*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/ff7984c3_5c229f1b PS31, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/aeb6d54f_9d75328f PS31, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/9fbd7666_d82a4c7d PS31, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/a80f3727_deee5811 PS31, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/35412665_54b1a55d PS31, Line 22: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/8d665a45_3d77f127 PS31, Line 22: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/80db9b16_8514c060 PS31, Line 24: /* Enable subsystem clock. Required for CPUCP PDMEM access*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/4a541f90_f4114c20 PS31, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/a93b1fb0_7c021248 PS31, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/a25a6a40_54aee4fb PS31, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/937b783c_eecb428a PS31, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/6b0d59da_0aa3d66d PS31, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/af95fe38_5f7f92b6 PS31, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/c838793b_5da32636 PS31, Line 32: bool cpucp_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/86f1bdb9_ad60d65e PS31, Line 32: bool cpucp_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/381178da_428f9687 PS31, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/56e7803e_9b066e58 PS31, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/896d14e2_e7b7e7b3 PS31, Line 35: struct prog cpucp_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/bb51eda3_72c025da PS31, Line 35: struct prog cpucp_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/8a162283_9c32827f PS31, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/b8558e6b_01e9020f PS31, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/a94b5d7e_e43a64e2 PS31, Line 38: cpucp_prepare(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/1fd748cc_6c6f9a84 PS31, Line 38: cpucp_prepare(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/c8fb0d75_865b1251 PS31, Line 40: if (prog_locate(&cpucp_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/da45d4e7_a6a4748b PS31, Line 40: if (prog_locate(&cpucp_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/add8c44d_e72a5caf PS31, Line 41: die("SOC imagpe: CPUCP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/238bc0d2_b089ce64 PS31, Line 41: die("SOC imagpe: CPUCP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/46d3f395_ccbd4b0a PS31, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/be2d72f5_e9e3f043 PS31, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/58433d69_f26632cb PS31, Line 44: if (!cpucp_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/d45a0779_69d50c35 PS31, Line 44: if (!cpucp_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/640e3b3d_c3416d19 PS31, Line 45: die("SOC image: CPUCP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/86a5bfb7_4f502173 PS31, Line 45: die("SOC image: CPUCP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/00170d63_5295b833 PS31, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/e8b24973_a57d71aa PS31, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/5c6909b4_e8c051dd PS31, Line 20: REGION_SIZE(dram_cpucp) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117951): https://review.coreboot.org/c/coreboot/+/49768/comment/c692eb48_a8f3072a PS31, Line 20: REGION_SIZE(dram_cpucp) / KiB); please, no spaces at the start of a line