25 Mar
2020
25 Mar
'20
10:15 p.m.
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39797 )
Change subject: vendorcode/intel/fsp: Update FSP header for Tiger Lake ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39797/2/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/tigerlake/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/39797/2/src/vendorcode/intel/fsp/fs... PS2, Line 896: 315
Thanks for the pointer Rohan. […]
I suspect that in that default header was updated and correct method is to build header first and then it should be put here. should is mark it as resolved ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/39797
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic743cb2134e6273a63c1212506c81ccbbdec442a
Gerrit-Change-Number: 39797
Gerrit-PatchSet: 2
Gerrit-Owner: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Caveh Jalali caveh@chromium.org
Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Comment-Date: Thu, 26 Mar 2020 05:15:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Wonkyu Kim wonkyu.kim@intel.com
Comment-In-Reply-To: Caveh Jalali caveh@chromium.org
Comment-In-Reply-To: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-MessageType: comment