Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31762 )
Change subject: arch/x86/postcar: Add separate timestamp for postcar stage ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31762/1/src/arch/x86/postcar.c File src/arch/x86/postcar.c:
https://review.coreboot.org/#/c/31762/1/src/arch/x86/postcar.c@44 PS1, Line 44: run_ramstage();
There is the following in run_ramstage(): […]
That addition should be conditionalized on ENV_POSTCAR and ENV_ROMSTAGE.
Are you referring this? https://review.coreboot.org/#/c/coreboot/+/31608/3/src/lib/prog_loaders.c if (!ENV_POSTCAR) timestamp_add_now(TS_END_ROMSTAGE);
Similarly, TS_END_ROMSTAGE should reside in run_postcar_phase() where you put TS_START_POSTCAR.
yes, i will take care of that. Saw your review comment
https://review.coreboot.org/#/c/31762/1/src/arch/x86/postcar_loader.c File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/#/c/31762/1/src/arch/x86/postcar_loader.c@178 PS1, Line 178: timestamp_add_now(TS_START_POSTCAR);
It seems to me for romstage and ramstage the start timestamp is in the stage itself. […]
I was trying to keep timestamp_add_now(TS_START_POSTCAR) inside postcar.c file main() function. But looks like timestamp has some prerequisites which is getting satisfied after cbmem_init() and by that time majority of postcar stage is over. Just to catch entire postcar stage activity, i just thought to keep this timestamp before start executing postcar stage.