[coreboot-gerrit] [S] Change in coreboot[master]: [UNTESTED] soc/amd/common/block/acpi/ivrs: conditionally generate eMM...

[Arthur Heymans (Code Review)]

Attention is currently required from: Felix Held, Jason Glenesk, Matt DeVillier, Raul Rangel.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75933?usp=email )

Change subject: [UNTESTED] soc/amd/common/block/acpi/ivrs: conditionally generate eMMC entry
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/75933/comment/23fce5ad_d512d778 :
PS1, Line 12: Where the PCI_DEVFN(0x13, 1) is from is currently unclear to me. There
            : is no PCI device 0x13 on bus 0 and the eMMC controller is also an MMIO
            : device and not a PCI device.
It had Naresh confused too, who wrote code to probe for the device before adding it, which failed and caused Linux to fail booting. I think it's worth adding a comment in the code.