Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31434 )
Change subject: soc/intel/cannonlake: Add PCH series check for CML LP PCH
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/31434/7/src/soc/intel/cannonlake/lpc.c
File src/soc/intel/cannonlake/lpc.c:
https://review.coreboot.org/#/c/31434/7/src/soc/intel/cannonlake/lpc.c@70
PS7, Line 70: uint8_t get_pch_series(void)
Not sure what you mean with `pch_series` or `base`. `base` is SoC […]
Let me clarify, PCH base is base address register to access PCH registers. This base address varies among various PCH IDs. Currently we are able to differentiate based on PCH_LP and PCH_H macro. In future, it may change for new PCH (where PCH might be LP only) but base address may be different. To handle this kind of scenarios, we have kept this function of getting PCH series.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31434
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I932585f6e7525830bd57ecfc372bf3120e7cca66
Gerrit-Change-Number: 31434
Gerrit-PatchSet: 7
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 25 Feb 2019 14:00:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment