[coreboot-gerrit] [L] Change in coreboot[main]: soc/mediatek: Remove redundant struct pad_func and PAD_* definitions

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Xi Chen, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84222?usp=email )

Change subject: soc/mediatek: Remove redundant struct pad_func and PAD_* definitions
......................................................................

Patch Set 3:

(6 comments)

File src/mainboard/google/cherry/bootblock.c:

https://review.coreboot.org/c/coreboot/+/84222/comment/57dd89c1_35916042?usp... :
PS3, Line 18: DOWN
Shouldn't this be `UP`? And the `gpio_set_pull` call should use `ptr[i].select`.

File src/soc/mediatek/common/include/soc/gpio_common.h:

https://review.coreboot.org/c/coreboot/+/84222/comment/eaf67403_9056bd06?usp... :
PS3, Line 53: struct pad_func {
            : 	gpio_t gpio;
            : 	u8 func;
            : 	enum pull_select select;
            : };
I thought you'd like to move this to gpio_defs.h as well?

File src/soc/mediatek/common/include/soc/gpio_defs.h:

https://review.coreboot.org/c/coreboot/+/84222/comment/dd898ff8_c1a1ce48?usp... :
PS3, Line 29: PAD_##name##_FUNC_##func1
`GPIO_FUNC(name, func1)`

https://review.coreboot.org/c/coreboot/+/84222/comment/e162c7fa_6d2013ee?usp... :
PS3, Line 45: 	
`(struct pad_func)`

File src/soc/mediatek/mt8183/i2c.c:

https://review.coreboot.org/c/coreboot/+/84222/comment/8498d569_57e3ef0d?usp... :
PS3, Line 56: struct pad_func {
Didn't you say you'd like to leave mt8183 untouched?

File src/soc/mediatek/mt8186/i2c.c:

https://review.coreboot.org/c/coreboot/+/84222/comment/4f10eb20_b8350228?usp... :
PS3, Line 111: GPIO_PULL_UP
Use `PAD_FUNC_UP` and write `.select` here. Same for all the files.