[coreboot-gerrit] Change in coreboot[master]: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )

Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................

Patch Set 68:

(3 comments)

https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x... 
File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x... 
PS68, Line 28: register "SkipExtGfxScan" = "1"
I think it would be better to set Aspeed VGA as primary:

register "SkipExtGfxScan" = "0"
register "PrimaryDisplay" = "Display_PCH_PCIe"

https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x... 
PS68, Line 146: 0x50
May be better to use the macro VR_CFG_AMP()

https://github.com/coreboot/coreboot/blob/ef7a3267870f126cc2f815812cfe545008...

https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x... 
PS68, Line 153: .icc_max = 0x1C
How did you calculate icc_max? In the case when CPU usage is at 100%, system doesn't reboot?