build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31588 )
Change subject: intelmetool: Consolidate all model support from upstream ......................................................................
Patch Set 1:
(93 comments)
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h File util/intelmetool/intelmetool.h:
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@110 PS1, Line 110: ((x) == PCI_DEVICE_ID_INTEL_82810 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@111 PS1, Line 111: ((x) == PCI_DEVICE_ID_INTEL_82810_DC ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@112 PS1, Line 112: ((x) == PCI_DEVICE_ID_INTEL_82810E_DC ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@113 PS1, Line 113: ((x) == PCI_DEVICE_ID_INTEL_82830M ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@114 PS1, Line 114: ((x) == PCI_DEVICE_ID_INTEL_82845 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@115 PS1, Line 115: ((x) == PCI_DEVICE_ID_INTEL_82865 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@116 PS1, Line 116: ((x) == PCI_DEVICE_ID_INTEL_82915 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@117 PS1, Line 117: ((x) == PCI_DEVICE_ID_INTEL_82945P ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@118 PS1, Line 118: ((x) == PCI_DEVICE_ID_INTEL_82945GM ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@119 PS1, Line 119: ((x) == PCI_DEVICE_ID_INTEL_82945GSE ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@120 PS1, Line 120: ((x) == PCI_DEVICE_ID_INTEL_82X58 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@121 PS1, Line 121: ((x) == PCI_DEVICE_ID_INTEL_ATOM_DXXX ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@122 PS1, Line 122: ((x) == PCI_DEVICE_ID_INTEL_I63XX ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@123 PS1, Line 123: ((x) == PCI_DEVICE_ID_INTEL_I5000X ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@124 PS1, Line 124: ((x) == PCI_DEVICE_ID_INTEL_I5000Z ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@125 PS1, Line 125: ((x) == PCI_DEVICE_ID_INTEL_I5000V ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@126 PS1, Line 126: ((x) == PCI_DEVICE_ID_INTEL_I5000P ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@127 PS1, Line 127: ((x) == PCI_DEVICE_ID_INTEL_82443LX ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@128 PS1, Line 128: ((x) == PCI_DEVICE_ID_INTEL_82443BX ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@130 PS1, Line 130: ((x) == PCI_DEVICE_ID_INTEL_82371XX ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@131 PS1, Line 131: ((x) == PCI_DEVICE_ID_INTEL_ICH ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@132 PS1, Line 132: ((x) == PCI_DEVICE_ID_INTEL_ICH0 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@133 PS1, Line 133: ((x) == PCI_DEVICE_ID_INTEL_ICH2 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@134 PS1, Line 134: ((x) == PCI_DEVICE_ID_INTEL_ICH4 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@135 PS1, Line 135: ((x) == PCI_DEVICE_ID_INTEL_ICH4M ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@136 PS1, Line 136: ((x) == PCI_DEVICE_ID_INTEL_ICH5 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@137 PS1, Line 137: ((x) == PCI_DEVICE_ID_INTEL_ICH6 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@138 PS1, Line 138: ((x) == PCI_DEVICE_ID_INTEL_ICH7DH ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@139 PS1, Line 139: ((x) == PCI_DEVICE_ID_INTEL_ICH7 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@140 PS1, Line 140: ((x) == PCI_DEVICE_ID_INTEL_ICH7M ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@141 PS1, Line 141: ((x) == PCI_DEVICE_ID_INTEL_ICH7MDH ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@142 PS1, Line 142: ((x) == PCI_DEVICE_ID_INTEL_NM10 )) space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@321 PS1, Line 321: ((x) == PCI_DEVICE_ID_INTEL_H81 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@322 PS1, Line 322: ((x) == PCI_DEVICE_ID_INTEL_B85 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@323 PS1, Line 323: ((x) == PCI_DEVICE_ID_INTEL_Q85 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@324 PS1, Line 324: ((x) == PCI_DEVICE_ID_INTEL_Q87 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@325 PS1, Line 325: ((x) == PCI_DEVICE_ID_INTEL_QM87 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@326 PS1, Line 326: ((x) == PCI_DEVICE_ID_INTEL_H87 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@327 PS1, Line 327: ((x) == PCI_DEVICE_ID_INTEL_HM87 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@328 PS1, Line 328: ((x) == PCI_DEVICE_ID_INTEL_Z87 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@329 PS1, Line 329: ((x) == PCI_DEVICE_ID_INTEL_X99 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@330 PS1, Line 330: ((x) == PCI_DEVICE_ID_INTEL_WILDCAT_LP1 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@331 PS1, Line 331: ((x) == PCI_DEVICE_ID_INTEL_WILDCAT_LP2 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@332 PS1, Line 332: ((x) == PCI_DEVICE_ID_INTEL_WILDCAT_LP3 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@333 PS1, Line 333: ((x) == PCI_DEVICE_ID_INTEL_WILDCAT_LP4 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@334 PS1, Line 334: ((x) == PCI_DEVICE_ID_INTEL_WILDCAT_LP5 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@335 PS1, Line 335: ((x) == PCI_DEVICE_ID_INTEL_WILDCAT_LP6 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@336 PS1, Line 336: ((x) == PCI_DEVICE_ID_INTEL_WILDCAT_LP7 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@337 PS1, Line 337: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_LP1 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@338 PS1, Line 338: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_LP2 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@339 PS1, Line 339: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_LP3 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@340 PS1, Line 340: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_LP4 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@341 PS1, Line 341: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_LP5 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@342 PS1, Line 342: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H0 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@343 PS1, Line 343: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H1 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@344 PS1, Line 344: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H2 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@345 PS1, Line 345: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H3 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@346 PS1, Line 346: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H4 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@347 PS1, Line 347: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H5 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@348 PS1, Line 348: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H6 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@349 PS1, Line 349: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H7 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@350 PS1, Line 350: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H8 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@351 PS1, Line 351: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H9 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@352 PS1, Line 352: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H10 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@353 PS1, Line 353: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H11 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@354 PS1, Line 354: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H12 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@355 PS1, Line 355: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H13 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@356 PS1, Line 356: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H14 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@357 PS1, Line 357: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H15 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@358 PS1, Line 358: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H16 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@359 PS1, Line 359: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H17 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@360 PS1, Line 360: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H18 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@361 PS1, Line 361: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H19 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@362 PS1, Line 362: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H20 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@363 PS1, Line 363: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H21 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@364 PS1, Line 364: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H22 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@365 PS1, Line 365: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H23 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@366 PS1, Line 366: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H24 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@367 PS1, Line 367: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H25 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@368 PS1, Line 368: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H26 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@369 PS1, Line 369: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H27 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@370 PS1, Line 370: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H28 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@371 PS1, Line 371: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H29 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@372 PS1, Line 372: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H30 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@373 PS1, Line 373: ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H31 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@374 PS1, Line 374: ((x) == PCI_DEVICE_ID_INTEL_LEWISBURG_1 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@375 PS1, Line 375: ((x) == PCI_DEVICE_ID_INTEL_LEWISBURG_2 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@376 PS1, Line 376: ((x) == PCI_DEVICE_ID_INTEL_LEWISBURG_3 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@377 PS1, Line 377: ((x) == PCI_DEVICE_ID_INTEL_LEWISBURG_4 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@378 PS1, Line 378: ((x) == PCI_DEVICE_ID_INTEL_LEWISBURG_5 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@379 PS1, Line 379: ((x) == PCI_DEVICE_ID_INTEL_LEWISBURG_6 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.h@380 PS1, Line 380: ((x) == PCI_DEVICE_ID_INTEL_LEWISBURG_7 ) || \ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.c File util/intelmetool/intelmetool.c:
https://review.coreboot.org/#/c/31588/1/util/intelmetool/intelmetool.c@142 PS1, Line 142: printf(CGRN "Good news, you have a `%s` so you have no ME " line over 80 characters