Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45187 )
Change subject: cpu/x86/sipi: Add x86_64 support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45187/1/src/cpu/x86/sipi_vector.S
File src/cpu/x86/sipi_vector.S:
https://review.coreboot.org/c/coreboot/+/45187/1/src/cpu/x86/sipi_vector.S@2...
PS1, Line 203: eax
I've run some tests and it's not possible to access C structs from assembly direclty. […]
The parts of the SIPI vector code that access it could be written using inline ASM, which could then access parts of the struct. Not a big deal.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45187
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53eae082123d1a12cfa97ead1d87d84db4a334c0
Gerrit-Change-Number: 45187
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 26 Oct 2020 15:31:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment