18 Oct
2019
18 Oct
'19
1:41 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35028 )
Change subject: superio/nuvoton/nct5539d: Add nuvoton NCT5539D specific superio.asl ......................................................................
Patch Set 9: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35028/7/src/superio/nuvoton/nct5539... File src/superio/nuvoton/nct5539d/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/35028/7/src/superio/nuvoton/nct5539... PS7, Line 167: #define PNP_DEVICE_ACTIVE ACT3
That is just copied form superio/nuvoton/nct6776/acpi/superio. […]
ah, had a look again and this is for the gpio interface in the i/o space
--
To view, visit https://review.coreboot.org/c/coreboot/+/35028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8d64e8faa74802ab0213d87881e57d4d9bd1c35
Gerrit-Change-Number: 35028
Gerrit-PatchSet: 9
Gerrit-Owner: Pavel Sayekat
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Pavel Sayekat
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 18 Oct 2019 13:41:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Comment-In-Reply-To: Pavel Sayekat
Gerrit-MessageType: comment