Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75039?usp=email )
Change subject: mb/google/rex: Enable ISH support ......................................................................
mb/google/rex: Enable ISH support
Enable ISH based on FW_CONFIG obtained from EC CBI. This is useful in case device is a tablet and motion sensors are handled by ISH instead of EC.
BUG=b:280329972,b:283023296 TEST= Set bit 21 of FW_CONFIG with CBI Boot rex board Check that ISH is enabled and loaded
Signed-off-by: Bernardo Perez Priego bernardo.perez.priego@intel.com Change-Id: Ibe0e1b8ce2c9b08ac6b1e6fef9bd19afc9b4f59f Reviewed-on: https://review.coreboot.org/c/coreboot/+/75039 Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Kapil Porwal kapilporwal@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/Kconfig.name M src/mainboard/google/rex/variants/rex0/overridetree.cb 3 files changed, 14 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Kapil Porwal: Looks good to me, approved
diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index cf038b7..4021fce 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -68,8 +68,8 @@ default "variants/baseboard/$(CONFIG_BASEBOARD_DIR)/devicetree.cb"
config FMDFILE - default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos_ec_ish-debug-fsp.fmd" if CHROMEOS && DRIVERS_INTEL_ISH && BUILDING_WITH_DEBUG_FSP - default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos_ec_ish.fmd" if CHROMEOS && DRIVERS_INTEL_ISH + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos_ec_ish-debug-fsp.fmd" if CHROMEOS && BOARD_GOOGLE_REX_EC_ISH && BUILDING_WITH_DEBUG_FSP + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos_ec_ish.fmd" if CHROMEOS && BOARD_GOOGLE_REX_EC_ISH default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-debug-fsp.fmd" if CHROMEOS && BUILDING_WITH_DEBUG_FSP default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" if CHROMEOS
diff --git a/src/mainboard/google/rex/Kconfig.name b/src/mainboard/google/rex/Kconfig.name index a4fa63a..13a0447 100644 --- a/src/mainboard/google/rex/Kconfig.name +++ b/src/mainboard/google/rex/Kconfig.name @@ -5,6 +5,7 @@ select BOARD_GOOGLE_BASEBOARD_REX select DRIVERS_GENERIC_MAX98357A select DRIVERS_GENESYSLOGIC_GL9755 + select DRIVERS_INTEL_ISH select DRIVERS_INTEL_SOUNDWIRE select DRIVERS_SOUNDWIRE_CS42L42 select DRIVERS_SOUNDWIRE_MAX98363 diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb index ab9596e..39a0a4d 100644 --- a/src/mainboard/google/rex/variants/rex0/overridetree.cb +++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb @@ -50,6 +50,10 @@ option VPU_DIS 0 option VPU_EN 1 end + field ISH 21 + option ISH_DISABLE 0 + option ISH_ENABLE 1 + end end
chip soc/intel/meteorlake @@ -277,6 +281,13 @@ .flags = PCIE_RP_LTR | PCIE_RP_AER, }" end #PCIE9 SSD card + device ref ish on + probe ISH ISH_ENABLE + chip drivers/intel/ish + register "firmware_name" = ""rex_ish.bin"" + device generic 0 on end + end + end device ref tbt_pcie_rp0 on end device ref tbt_pcie_rp2 on end device ref vpu on