Attention is currently required from: Sridhar Siricilla, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58157 )
Change subject: soc/intel/common/cse: Reorganize firmware update checks for CSE Lite ......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/58157/comment/0b47e4bf_7805a43e PS5, Line 651: (status == CSE_UPDATE_CORRUPTED
If the last update is downgrade case, then coreboot first clears the runtime data and triggers downg […]
I was thinking of this case:
1. CSE region getting corrupted for some reason (it could be an update being applied or some other reason) 2. Suppose user recovers their device with an OS image which has an older firmware i.e. firmware older than what was being flashed and what was present on the device before. This would be a case of downgrade via recovery. In that case, we might not have erased data already.
Given that erasing data doesn't have any other side effects and it should be an extremely rare case, I will keep this check as is.