Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36123 )
Change subject: purism/librem_skl: add libgfxinit support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36123/1/src/mainboard/purism/librem...
File src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36123/1/src/mainboard/purism/librem...
PS1, Line 7: register "gpu_pp_backlight_off_delay_ms" = "200"
I'll dump from a few different devices and adjust using the most conservative values
these values match those from both the KabyLake FSP sample VBT, and the VBT files extracted from the Librem's AMI/UEFI firmware. I'm good with using them as-is.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36123
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9582065603417e53704244e95dde51a59f709664
Gerrit-Change-Number: 36123
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Oct 2019 17:25:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
