Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42062 )
Change subject: src/*: Update makefiles to exclude x86 code from psp-verstage ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42062/9/src/cpu/x86/lapic/Makefile.... File src/cpu/x86/lapic/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/9/src/cpu/x86/lapic/Makefile.... PS9, Line 9: verstage_x86-y += boot_cpu.c
I hope the syntax is expanded, some day, such that we have "all_x86-y += " for cases like these. […]
Sure, I think that's a nice-to-have.
https://review.coreboot.org/c/coreboot/+/42062/9/src/drivers/pc80/pc/Makefil... File src/drivers/pc80/pc/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/9/src/drivers/pc80/pc/Makefil... PS9, Line 10: verstage_x86-y += i8254.c
So it's excluded because it has inline asm? Not because of <arch/io.h>. […]
Yes, it's because of the inline asm.