Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46442 )
Change subject: mb/google/kukui: fix SKUID config for burnet/esche
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46442/1/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/46442/1/src/mainboard/google/kukui/...
PS1, Line 99: if (CONFIG(BOARD_GOOGLE_BURNET)) {
: cached_sku_id = (0x10 | get_adc_index(SKU_ID_CHANNEL));
: return cached_sku_id;
: }
:
I agree to hard-code LCM_ID to 1 (even if we resolve the floating LCM_ID issue from HW). […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46442
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b43b9153315ec65e9168c4e84ea844dff14d446
Gerrit-Change-Number: 46442
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-Comment-Date: Tue, 20 Oct 2020 07:43:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Kevin Chiu
Kevin.Chiu@quantatw.com
Comment-In-Reply-To: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-MessageType: comment