Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43335 )
Change subject: soc/intel/xeon_sp/cpx: use HOB_TYPE_GUID_EXTENSION to interpret platform HOBs
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43335/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43335/1//COMMIT_MSG@10
PS1, Line 10: it does not have
they do not have
Done
https://review.coreboot.org/c/coreboot/+/43335/1//COMMIT_MSG@12
PS1, Line 12: errorneous
no second `r`: erroneous
Done
https://review.coreboot.org/c/coreboot/+/43335/1//COMMIT_MSG@14
PS1, Line 14: heade
header
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43335
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib99bce39e6eb2aeb95242dfba36774653bbe91fd
Gerrit-Change-Number: 43335
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 10 Jul 2020 16:09:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment