ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43323 )
Change subject: libpayload: allow nonblocking delay and more than one delay
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43323/8/payloads/libpayload/arch/x8...
File payloads/libpayload/arch/x86/apic.c:
https://review.coreboot.org/c/coreboot/+/43323/8/payloads/libpayload/arch/x8...
PS8, Line 122: disable_interrupts();
Is there any reason to keep this?
I think it should be there. while timer_waiting is a volatile, wrapping changes to it in disable/enable just feels a bit better to me.
https://review.coreboot.org/c/coreboot/+/43323/8/payloads/libpayload/arch/x8...
PS8, Line 127: enable_interrupts();
and this?
yes, because in my mind lines 123-126 represent a critical section that ought to be protected with a cli/sti.
It's a bit of probably unnecessary drama, but I don't see that it does any harm.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43323
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib11aeee5b7da81287166ac68fc327e7ae62d1b84
Gerrit-Change-Number: 43323
Gerrit-PatchSet: 8
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 15 Jul 2020 18:30:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Gerrit-MessageType: comment