Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48220 )
Change subject: soc/amd: move smi_util to common block ......................................................................
Patch Set 1:
(1 comment)
How much did you compare these registers/functions with the upcoming devices? IIRC I was reluctant to move SMI stuff to common because there were a number of differences between ST and PCO. I _think_ we're OK with what you have here... Using addresses like SMI_REG_CONTROL0 may eventually need to change (and I'm not sure what Server devices look like, Promontory, etc.), but we can address that later if necessary.
https://review.coreboot.org/c/coreboot/+/48220/1/src/soc/amd/common/block/sm... File src/soc/amd/common/block/smi/smi_util.c:
https://review.coreboot.org/c/coreboot/+/48220/1/src/soc/amd/common/block/sm... PS1, Line 35: Valid values are 0 thru 23 I can't recall, without digging, if this is typically consistent across devices.