Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47579 )
Change subject: soc/intel/xeon_sp: Fix skx SATA drive boot issue ......................................................................
Patch Set 2: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/47579/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47579/2//COMMIT_MSG@9 PS2, Line 9: cpx CPX
https://review.coreboot.org/c/coreboot/+/47579/2//COMMIT_MSG@9 PS2, Line 9: Skx I'd use uppercase: SKX
https://review.coreboot.org/c/coreboot/+/47579/2//COMMIT_MSG@9 PS2, Line 9: x2apic I'd use uppercase: X2APIC
https://review.coreboot.org/c/coreboot/+/47579/2//COMMIT_MSG@9 PS2, Line 9: skx SKX
https://review.coreboot.org/c/coreboot/+/47579/2/src/soc/intel/xeon_sp/nb_ac... File src/soc/intel/xeon_sp/nb_acpi.c:
https://review.coreboot.org/c/coreboot/+/47579/2/src/soc/intel/xeon_sp/nb_ac... PS2, Line 447: #if
Can you do this with C code and add a comment?
Definitely:
/* SKX FSP doesn't support X2APIC, but CPX FSP does */ if (CONFIG(SOC_INTEL_SKYLAKE_SP)) flags |= DMAR_X2APIC_OPT_OUT;