Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35040 )
Change subject: soc/intel/common/block: Provide mmc.c for setting dll registers
......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35040/15//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35040/15//COMMIT_MSG@7
PS15, Line 7: soc/intel/common/block: Provide mmc.c for setting dll registers.
Please remove the dot/period at the end of the commit message summary.
Done
https://review.coreboot.org/c/coreboot/+/35040/15//COMMIT_MSG@13
PS15, Line 13: Notice: set_mmc_dll function will override the dll values in FSP.
Please add a blank line above.
Done
https://review.coreboot.org/c/coreboot/+/35040/15//COMMIT_MSG@17
PS15, Line 17: overrided
overridden?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35040
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3c72b9851f41585ec099d8ae83a721af87ed383
Gerrit-Change-Number: 35040
Gerrit-PatchSet: 16
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 27 Aug 2019 10:45:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment