[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Refactor and consolidate code for spi base

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43307 )

Change subject: soc/amd/common: Refactor and consolidate code for spi base
......................................................................

Patch Set 8:

(3 comments)

https://review.coreboot.org/c/coreboot/+/43307/6/src/soc/amd/common/block/in... 
File src/soc/amd/common/block/include/amdblocks/spi.h:

https://review.coreboot.org/c/coreboot/+/43307/6/src/soc/amd/common/block/in... 
PS6, Line 8: extern uintptr_t spi_base;
> I agree.  I'll revert back to the old code, then look at reorganizing things in a follow-on patch.

Done

https://review.coreboot.org/c/coreboot/+/43307/6/src/soc/amd/common/block/sp... 
File src/soc/amd/common/block/spi/fch_spi_ctrl.c:

https://review.coreboot.org/c/coreboot/+/43307/6/src/soc/amd/common/block/sp... 
PS6, Line 35: spi_base
> Good point. I'd prefer encapsulation.

encapsulated in a single file in a follow-on patch.  cb:43772

https://review.coreboot.org/c/coreboot/+/43307/6/src/soc/amd/common/block/sp... 
PS6, Line 35: 	return read8((void *)(spi_base + reg));
> I would not call it slower. For some compilation units, it may double the .text section size.

Addressed in the commit message in a follow-on patch.  cb:43772