Attention is currently required from: Alper Nebi Yasak, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80375?usp=email )
Change subject: drivers/qemu: Split Cirrus display support from Bochs display support ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/drivers/emulation/qemu/Kconfig:
https://review.coreboot.org/c/coreboot/+/80375/comment/65e9ecd9_c6608c31 : PS1, Line 26: DRIVERS_EMULATION_QEMU_CIRRUS
Should Cirrus and Bochs be mutually exclusive?
One could build one image for both and use it with different QEMU settings, i.e. switching graphics cards is most easy with QEMU :D so, why not allow that? The right driver would be picked at runtime by PCI ID.
In any case, I don't think we have to duplicate the resolution Kconfigs. Can we makes those generic DRIVERS_EMULATION_QEMU_X/YRES?