Attention is currently required from: Nico Huber, Subrata Banik, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61380 )
Change subject: soc/inte/common: Add support to control coreboot and Intel SoC features ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/61380/comment/23b79274_86614f01 PS2, Line 666: is_cse_fw_update_enabled
WDYT about this ? […]
CSE FW update should work as below :
* SOC_INTEL_COMMON_BLOCK_DEBUG_FEATURE & SOC_INTEL_CSE_RW_UPDATE are enabled -> decision is based on debug flag
* SOC_INTEL_CSE_RW_UPDATE is only enabled -> CSE FW update should be enabled
* SOC_INTEL_COMMON_BLOCK_DEBUG_FEATURE is alone enabled -> skip cse fw update
* if both flags are not enabled -> skip cse fw update
Even my code doesn't meet above conditions. I will push update.