[coreboot-gerrit] [M] Change in coreboot[main]: region: Introduce region_create() functions

[Nico Huber (Code Review)]

Attention is currently required from: Andrey Petrov, Felix Held, Felix Singer, Julius Werner, Jérémy Compostella, Martin L Roth, Maximilian Brune, Ronak Kanabar.

Nico Huber has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/79905?usp=email )

Change subject: region: Introduce region_create() functions
......................................................................

Patch Set 8:

(3 comments)

File src/include/cpu/x86/smm.h:

https://review.coreboot.org/c/coreboot/+/79905/comment/111ff428_87e3b7c6?usp... :
PS7, Line 147: 	if (region_create_untrusted(&r, (uintptr_t)ptr, len))
> region_create_untrusted returns enum cb_err, so i'd prefer checking the return value against CB_SUCC […]

Done

File util/cbfstool/cbfstool.c:

https://review.coreboot.org/c/coreboot/+/79905/comment/fd71724f_678d28dc?usp... :
PS7, Line 334: 	if (region_create_untrusted(
> i'd prefer to check the return values for the two region_create_untrusted calls against CB_SUCCESS h […]

Done

Actually, don't like how it looks, but don't know how to do better and
be consistent.

File util/cbfstool/cse_serger.c:

https://review.coreboot.org/c/coreboot/+/79905/comment/a10b0c7e_1ab0a98b?usp... :
PS7, Line 833: 	if (region_create_untrusted(r, offset, size)) {
> same here

Done