Attention is currently required from: Michael Niewöhner, Nicholas Chin, Nico Huber.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80695?usp=email )
Change subject: include/device: Merge enums from azalia_device.h and azalia.h ......................................................................
Patch Set 4:
(1 comment)
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/80695/comment/e87e51ab_925bb081 : PS4, Line 128: conn
If I'm not mistaken, you could do `AZALIA_##conn` here. Then the macro […]
That would open a can of worms once you start using more "complex" things. For example, my hda-decoder tries to preserve vendor values in the misc field by using ORs (e.g. `NO_JACK_PRESENCE_DETECT | 0x2`). This would break if you switched the order. A similar issue goes for locations (CB:80740).
I also prefer to minimize macro magic as well.