build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61448 )
Change subject: drivers/i2c/cs35l53: Add driver for generating device in SSDT ......................................................................
Patch Set 1:
(5 comments)
File src/drivers/i2c/cs35l53/cs35l53.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139358): https://review.coreboot.org/c/coreboot/+/61448/comment/419ac2f6_0014aa22 PS1, Line 69: if ((config->boost_peak_milliamp > 4500) || that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139358): https://review.coreboot.org/c/coreboot/+/61448/comment/4fc3e96a_790e561b PS1, Line 82: acpi_dp_add_integer(dsd, "cirrus,gpio1-polarity-invert", config->gpio1_polarity_invert ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139358): https://review.coreboot.org/c/coreboot/+/61448/comment/a508b4b3_e08c74dc PS1, Line 83: acpi_dp_add_integer(dsd, "cirrus,gpio1-output-enable", config->gpio1_output_enable ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139358): https://review.coreboot.org/c/coreboot/+/61448/comment/d08ae80f_8edeea08 PS1, Line 85: acpi_dp_add_integer(dsd, "cirrus,gpio2-polarity-invert", config->gpio2_polarity_invert ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139358): https://review.coreboot.org/c/coreboot/+/61448/comment/44db72c5_acb76c6b PS1, Line 86: acpi_dp_add_integer(dsd, "cirrus,gpio2-output-enable", config->gpio2_output_enable ? 1 : 0); line over 96 characters