21 Mar
2022
21 Mar
'22
10:18 p.m.
Attention is currently required from: Varshit B Pandya, Lance Zhao, Subrata Banik, Rizwan Qureshi. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62944 )
Change subject: drivers/intel/dptf: Add support for Power participant ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/62944/comment/1c687c64_1a64b227 PS2, Line 387: acpigen_write_device_end(); /* TPWR Power Participant Device */ this is kind of awkward, having the write_device_end() in a separate function, why can't this just go in write_create_tpwr?
--
To view, visit https://review.coreboot.org/c/coreboot/+/62944
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I437e509f58df1777d75e5981f0a5a63095ccb6a3
Gerrit-Change-Number: 62944
Gerrit-PatchSet: 2
Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Varshit B Pandya varshit.b.pandya@intel.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Comment-Date: Mon, 21 Mar 2022 21:18:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment