Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74381 )
Change subject: ec/acpi/ec: replace misleading "recv_ec_data_timeout" console output ......................................................................
ec/acpi/ec: replace misleading "recv_ec_data_timeout" console output
In the non-timeout case in recv_ec_data_timeout, a message like this one will get printed at BIOS_SPEW log level: "recv_ec_data_timeout: 0x00". The "timeout" part of the function name corresponds to what the function does, but the message will only be printed when not running into the timeout which is a bit misleading and might suggest a problem when there is none. To avoid this possible confusion, don't use the function name in the printk, but use "Data from EC:" instead.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I521f67517f64fc64e24853d96730c3f9459f1ccc --- M src/ec/acpi/ec.c 1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/74381/1
diff --git a/src/ec/acpi/ec.c b/src/ec/acpi/ec.c index fbd9acd..f183801 100644 --- a/src/ec/acpi/ec.c +++ b/src/ec/acpi/ec.c @@ -88,7 +88,7 @@ }
data = inb(ec_data_reg); - printk(BIOS_SPEW, "%s: 0x%02x\n", __func__, data); + printk(BIOS_SPEW, "Data from EC: 0x%02x\n", data);
return data; }