Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39859 )
Change subject: nb/intel/i945: Make some cosmetic changes ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39859/3/src/northbridge/intel/i945/... File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/39859/3/src/northbridge/intel/i945/... PS3, Line 2557: */
Ack
Um, what Paul meant is this:
/* We have a bank with a non-zero size... Remember it for the next offset we have to calculate */
If that looks bad, you can also use this:
/* * We have a bank with a non-zero size... * Remember it for the next offset we have to calculate */
In any case, please use three points for the ellipsis [1]. Also, since both sentences don't fit in the same line, you can put each sentence on a different line so that they are not broken.
[1]: https://en.wikipedia.org/wiki/Ellipsis