Attention is currently required from: Furquan Shaikh, Subrata Banik, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55675 )
Change subject: soc/intel/common/block/cse: Add BWG error recovery to EOP failure
......................................................................
Patch Set 13:
(1 comment)
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/55675/comment/8c5288cd_0bab5ba4
PS12, Line 156: "error\nYour system may be in an insecure state.");
Subrata, this late in boot, doesn't using the PCR interface have to happen in SMM? (also note thes […]
Ahh true, but there is also the call to `cse_disable_mei_bus()`, which disables HECI on the CSE side first...
How about this pseudo-logic:
```
bool fail = false;
if (!cse_disable_mei_bus()) {
if (CONFIG(HECI_DISABLE_USING_SMM)) {
config_t *config = config_of_soc();
config->HeciEnabled = 0;
}
}
if (!cse_disable_mei_devices()) {
die(...);
}
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55675
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06abf36a9d9d8a5f2afba6002dd5695dd2107db1
Gerrit-Change-Number: 55675
Gerrit-PatchSet: 13
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 30 Jun 2021 19:02:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment