Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46613 )
Change subject: mb/google/dedede/var/magolor: Configure I2C high and low time
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46613/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46613/1//COMMIT_MSG@12
PS1, Line 12: TEST=Measured the I2C bus frequency reduce to 387 KHz.
What was the value before?
https://review.coreboot.org/c/coreboot/+/46613/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46613/1/src/mainboard/google/dedede...
PS1, Line 27: .speed = I2C_SPEED_FAST,
: .speed_config[0] = {
: .speed = I2C_SPEED_FAST,
Is `.speed` really specified twice?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46613
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f5b81815f86db7bdcea95a95b9c9b235b4a34b1
Gerrit-Change-Number: 46613
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Oct 2020 10:22:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment