Attention is currently required from: Raul Rangel, Furquan Shaikh, Marshall Dawson, Paul Menzel, Karthik Ramasubramanian, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56919 )
Change subject: soc/amd/common: Skip psp_verstage on S0i3 resume ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56919/comment/450322fb_a5423650 PS1, Line 8:
Please add a reasoning, why psp_verstage is not needed.
Done
https://review.coreboot.org/c/coreboot/+/56919/comment/2606a962_bef10b63 PS1, Line 10: :
=
Done
https://review.coreboot.org/c/coreboot/+/56919/comment/a2f779b2_b36b52c1 PS1, Line 10: S0i3
psp_verstage
Done
File src/soc/amd/common/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/56919/comment/75e1bfb6_24e2151e PS1, Line 205: Currently, we want to skip running verstage on all S0i3 resumes. This relies : on an assumption that the PSP will be checksumming all of its components.
Thanks for the background, Karthik. […]
I don't think the plan was to drop this. You might want to talk to Eric about that, because the decision in yesterday's meeting was to do both. Let me know what's decided - I don't really care either way, but it's very difficult when I have two people pulling in different directions.
I'll update the commit message saying that the PSP shouldn't even load psp_verstage on resume though.