build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43087 )
Change subject: Added GBYT4 port ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/gpi... File src/mainboard/unk/gbyt4/gpio.c:
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/gpi... PS1, Line 208: struct soc_gpio_config* mainboard_get_gpios(void) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/irq... File src/mainboard/unk/gbyt4/irqroute.h:
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/irq... PS1, Line 7: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/irq... PS1, Line 15: #define PIRQ_PIC_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/rom... File src/mainboard/unk/gbyt4/romstage.c:
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/rom... PS1, Line 56: &dual_channel);*/ code indent should use tabs where possible