18 Feb
2021
18 Feb
'21
10:39 p.m.
Attention is currently required from: Lance Zhao, Jingle Hsu. Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39979 )
Change subject: intel/xeon_sp: Add ACPI to control GPIO ......................................................................
Patch Set 46:
(2 comments)
Patchset:
PS46: Thanks for the review and help with this work!
File src/soc/intel/xeon_sp/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/39979/comment/213a2e2f_6693c6b0 PS41, Line 19: Memory32Fixed (ReadWrite, 0, 0, COM1)
COM2 has been added in the patch-set 42.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/39979
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07c882077eb3c035faae81641bc860e69db224b4
Gerrit-Change-Number: 39979
Gerrit-PatchSet: 46
Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam anjaneya.chagam@intel.com
Gerrit-Reviewer: Jingle Hsu jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Marc Jones marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Jingle Hsu jingle_hsu@wiwynn.com
Gerrit-Comment-Date: Thu, 18 Feb 2021 22:39:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov max.senia.poliak@gmail.com
Comment-In-Reply-To: Jingle Hsu jingle_hsu@wiwynn.com
Gerrit-MessageType: comment