Attention is currently required from: Hung-Te Lin.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74341 )
Change subject: soc/mediatek: Add support for regulator VIO18
......................................................................
Patch Set 1:
(1 comment)
File src/soc/mediatek/mt8186/mt6366.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173880):
https://review.coreboot.org/c/coreboot/+/74341/comment/133721bf_1a5a65f6
PS1, Line 959: break;
break is not useful after a return
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74341
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c3aa105e648b87fc39f881d762002f67b4422b5
Gerrit-Change-Number: 74341
Gerrit-PatchSet: 1
Gerrit-Owner: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Tue, 11 Apr 2023 12:18:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment