Attention is currently required from: Bob Moragues, Bora Guvendik, Cliff Huang, Hannah Williams, Poornima Tom, Ravishankar Sarawadi.
Subrata Banik has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/81790?usp=email )
Change subject: Wifi: Support 320Mhz Bandwidth Enablement per MCC
......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81790/comment/a2fc2962_6d4e52b6?usp... :
PS2, Line 7: Wifi
driver/wifi?
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/81790/comment/4889658e_39304f71?usp... :
PS2, Line 486: WiFi320MHzPerMcc
avoid camelcase
File src/include/sar.h:
https://review.coreboot.org/c/coreboot/+/81790/comment/f299209c_a094616a?usp... :
PS2, Line 64: WiFi320MHzPerMcc
avoid camel case
https://review.coreboot.org/c/coreboot/+/81790/comment/c514ebea_05c3a708?usp... :
PS2, Line 65: __packed
any reason for using `packed`?
File src/vendorcode/google/chromeos/sar.c:
https://review.coreboot.org/c/coreboot/+/81790/comment/bebf59a4_61e0cd45?usp... :
PS2, Line 219: *
don't delete please
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81790?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie76794825f1a0104d199c078aa4ffc714aa95b17
Gerrit-Change-Number: 81790
Gerrit-PatchSet: 2
Gerrit-Owner: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bob Moragues
moragues@google.com
Gerrit-CC: Dinesh Sharma
dinesh.sharma@intel.corp-partner.google.com
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-CC: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Poornima Tom
poornima.tom@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Comment-Date: Tue, 25 Jun 2024 10:25:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No