Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35998 )
Change subject: mb/lenovo/{x200,t400}: Add VBOOT support ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35998/14/src/mainboard/lenovo/t400/... File src/mainboard/lenovo/t400/vboot-rwa.fmd:
https://review.coreboot.org/c/coreboot/+/35998/14/src/mainboard/lenovo/t400/... PS14, Line 6: } Same gaps here, intentional?
https://review.coreboot.org/c/coreboot/+/35998/12/src/mainboard/lenovo/x200/... File src/mainboard/lenovo/x200/vboot-rwa.fmd:
https://review.coreboot.org/c/coreboot/+/35998/12/src/mainboard/lenovo/x200/... PS12, Line 5: SI_ME@0x3000 0x4ed000
/me stumbled and fell into a 64KiB gap […]
Done
https://review.coreboot.org/c/coreboot/+/35998/12/src/mainboard/lenovo/x200/... PS12, Line 6: }
1MiB gap, intended? […]
Done