Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83989?usp=email )
Change subject: soc/mediatek: Move SNFC pad_func into MediaTek common directory ......................................................................
Patch Set 4:
(3 comments)
File src/soc/mediatek/common/flash_controller.c:
https://review.coreboot.org/c/coreboot/+/83989/comment/8b5d78bf_beb4505a?usp... : PS4, Line 236: __func__, strength, pad_func->gpio.id); Change the return type to int and return -1 here.
``` if (...) { printk(ERR...); return -1; }
printk(DEBUG...); ```
File src/soc/mediatek/common/include/soc/flash_controller_common.h:
https://review.coreboot.org/c/coreboot/+/83989/comment/f339e572_74a6c4d6?usp... : PS4, Line 79: /* pad func */ Remove comment as it explains nothing.
https://review.coreboot.org/c/coreboot/+/83989/comment/d5761fbf_aacab7bc?usp... : PS4, Line 80: struct pad_func { : gpio_t gpio; : u8 func; : enum pull_select select; : };
Redefinition in MT8195.
Maybe we can rename it to something like `snfc_pad_func` or `mtk_snfc_pad_func`. MTK, please decide an appropriate name.