[coreboot-gerrit] [XL] Change in coreboot[main]: soc/intel/ptl: Add GPIOs for Panther Lake SOC

[Cliff Huang (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Elyes Haouas, Jamie Ryu, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N, Ravishankar Sarawadi, Saurabh Mishra, Subrata Banik, Wonkyu Kim.

Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83789?usp=email )

Change subject: soc/intel/ptl: Add GPIOs for Panther Lake SOC
......................................................................

Patch Set 61:

(8 comments)

File src/soc/intel/pantherlake/acpi/gpio.asl:

https://review.coreboot.org/c/coreboot/+/83789/comment/e065482c_2374a14e?usp... :
PS55, Line 60: /* Device Properties for _DSD */,
> These comments are generated from .asl to .dsl file by iasl. The template that we started with gpio. […]

Done

https://review.coreboot.org/c/coreboot/+/83789/comment/cf8229c3_b1fe2d80?usp... :
PS55, Line 84: 0x10
> I checked with pinctrl owner, we will remove this package. […]

Done

File src/soc/intel/pantherlake/include/soc/gpio_defs.h:

https://review.coreboot.org/c/coreboot/+/83789/comment/ce8ca17b_d58b4750?usp... :
PS55, Line 257: GPP_V
> can you use `_start_` in between to make it clear? […]

Done

File src/soc/intel/pantherlake/include/soc/gpio_soc_defs.h:

https://review.coreboot.org/c/coreboot/+/83789/comment/728f16de_519615c0?usp... :
PS55, Line 36: Community0
> is there any specific syntax to follow here? […]

Done

File src/soc/intel/pantherlake/include/soc/gpio_soc_defs.h:

https://review.coreboot.org/c/coreboot/+/83789/comment/05aef567_149d42a8?usp... :
PS49, Line 15: 0x1
> INC(GPP_V)

Done

https://review.coreboot.org/c/coreboot/+/83789/comment/34b1c11e_6efd8d26?usp... :
PS49, Line 36: #define GPP_COMM0_NAME "Community0"
             : #define GPP_COMM1_NAME "Community1"
             : #define GPP_COMM3_NAME "Community3"
             : #define GPP_COMM4_NAME "Community4"
             : #define GPP_COMM5_NAME "Community5"
             : 
             : #define GPP_V_NAME		"GPP_V"
             : #define GPP_C_NAME		"GPP_C"
             : #define GPP_F_NAME		"GPP_F"
             : #define GPP_E_NAME		"GPP_E"
             : #define GPP_CPUJTAG_NAME	"GPUJTAG"
             : #define GPP_H_NAME		"GPP_H"
             : #define GPP_A_NAME		"GPP_A"
             : #define GPP_VGPIO3_NAME		"vGPIO_3"
             : #define GPP_S_NAME		"GPP_S"
             : #define GPP_B_NAME		"GPP_B"
             : #define GPP_D_NAME		"GPP_D"
             : #define GPP_VGPIO_NAME		"vGPIO"
             :
> This are used in gpio.asl. gpio.h is not included directly in gpio.asl. Let me try.

Done

https://review.coreboot.org/c/coreboot/+/83789/comment/af6a9b96_7932c38f?usp... :
PS49, Line 58: 1
> INC(COMM_0)

Done

https://review.coreboot.org/c/coreboot/+/83789/comment/5e5050b7_125261da?usp... :
PS49, Line 250: #define NUM_COM1_GPP_GROUPS	2
> This marco is does not count the non GPP_[grp]_[num] group in a community. […]

Done