[coreboot-gerrit] [S] Change in coreboot[master]: src/drivers/ipmi: accomodate BMC revision being 0

[Jonathan Zhang (Code Review)]

Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68685 )

Change subject: src/drivers/ipmi: accomodate BMC revision being 0
......................................................................

src/drivers/ipmi: accomodate BMC revision being 0

BMC major/minor revision may be 0. Get the value directly from
BMC without checking to accomodate such situation.

Signed-off-by: Tim Chu 
Signed-off-by: Jonathan Zhang

Change-Id: I0e08c6d02de8f6efceb69b6d6cebad9d61cfd20e
---
M src/drivers/ipmi/ipmi_kcs_ops.c
1 file changed, 17 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/68685/1

diff --git a/src/drivers/ipmi/ipmi_kcs_ops.c b/src/drivers/ipmi/ipmi_kcs_ops.c
index a2ad7ab..28ced49 100644
--- a/src/drivers/ipmi/ipmi_kcs_ops.c
+++ b/src/drivers/ipmi/ipmi_kcs_ops.c
@@ -259,14 +259,8 @@

void ipmi_bmc_version(uint8_t *ipmi_bmc_major_revision, uint8_t *ipmi_bmc_minor_revision)
 {
-	if (!bmc_revision_major || !bmc_revision_minor) {
-		printk(BIOS_ERR, "IPMI: BMC revision missing\n");
-		*ipmi_bmc_major_revision = 0;
-		*ipmi_bmc_minor_revision = 0;
-	} else {
-		*ipmi_bmc_major_revision = bmc_revision_major;
-		*ipmi_bmc_minor_revision = bmc_revision_minor;
-	}
+	*ipmi_bmc_major_revision = bmc_revision_major;
+	*ipmi_bmc_minor_revision = bmc_revision_minor;
 }

#if CONFIG(GENERATE_SMBIOS_TABLES)