Attention is currently required from: Nico Huber, Paul Menzel.
Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/82632?usp=email )
Change subject: sio/nuvoton: Implement a common ramstage ACPI LDN helper
......................................................................
Patch Set 6:
(1 comment)
File src/superio/nuvoton/nct5572d/superio.c:
https://review.coreboot.org/c/coreboot/+/82632/comment/27cedfb8_69435804?usp... :
PS5, Line 13: #define MAINBOARD_POWER_OFF 0
: #define MAINBOARD_POWER_ON 1
: #define MAINBOARD_POWER_KEEP 2
Not needed anymore.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82632?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibaddcaa2d77c5b06ddfbb6dbaac00df5e72dd4bd
Gerrit-Change-Number: 82632
Gerrit-PatchSet: 6
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 03 Jun 2024 13:15:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de